fix(config): correct from_yaml return type and handle empty YAML files#20
Merged
Conversation
Two fixes:
1. Return type annotation changed from BaseTrainConfig to Self, so
SFTConfig.from_yaml() correctly types as SFTConfig (fixes mypy
strict and IDE autocomplete in notebooks)
2. Guard against yaml.safe_load() returning None for empty files
with (data or {}), returning defaults instead of crashing
Fixes #19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
from_yamlreturn annotation fromBaseTrainConfigtoSelf(fixes mypy strict + notebook IDE autocomplete)yaml.safe_load()returningNonefor empty YAML files with(data or {}), returning all defaults instead of crashing with confusingTypeErrorFixes #19
Test plan
test_from_yaml_empty_filefor empty filetest_from_yaml_empty_docfor YAML with only---